Move PerformanceEntryReporter to its own target #43854
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55646391 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Apr 4, 2024
Summary: Pull Request resolved: facebook#43854 Changelog: [internal] ## Context This is part of a refactor to decouple the performance entry reporter from the rendering infra and from the native module that uses it. ## Changes This moves the `PerformanceEntryReporter` and related classes to their own target in `ReactCommon/react/performance/timeline` that's not coupled with any rendering logic. Differential Revision: D55646391
|
This pull request was exported from Phabricator. Differential Revision: D55646391 |
rubennorte
force-pushed
the
export-D55646391
branch
from
dcbd502
to
bff93cd
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: facebook#43854 Changelog: [internal] ## Context This is part of a refactor to decouple the performance entry reporter from the rendering infra and from the native module that uses it. ## Changes This moves the `PerformanceEntryReporter` and related classes to their own target in `ReactCommon/react/performance/timeline` that's not coupled with any rendering logic. Differential Revision: D55646391
rubennorte
force-pushed
the
export-D55646391
branch
from
bff93cd
to
a5c3ea2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55646391 |
Base commit: 2fcdab4 |
|
This pull request was exported from Phabricator. Differential Revision: D55646391 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: facebook#43854 Changelog: [internal] ## Context This is part of a refactor to decouple the performance entry reporter from the rendering infra and from the native module that uses it. ## Changes This moves the `PerformanceEntryReporter` and related classes to their own target in `ReactCommon/react/performance/timeline` that's not coupled with any rendering logic. Differential Revision: D55646391
rubennorte
force-pushed
the
export-D55646391
branch
from
a5c3ea2
to
5ccde02
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Apr 5, 2024
Summary: Pull Request resolved: facebook#43854 Changelog: [internal] ## Context This is part of a refactor to decouple the performance entry reporter from the rendering infra and from the native module that uses it. ## Changes This moves the `PerformanceEntryReporter` and related classes to their own target in `ReactCommon/react/performance/timeline` that's not coupled with any rendering logic. Differential Revision: D55646391
rubennorte
force-pushed
the
export-D55646391
branch
from
5ccde02
to
97f7e16
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55646391 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D55646391 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Apr 8, 2024
Summary: Pull Request resolved: facebook#43854 Changelog: [internal] ## Context This is part of a refactor to decouple the performance entry reporter from the rendering infra and from the native module that uses it. ## Changes This moves the `PerformanceEntryReporter` and related classes to their own target in `ReactCommon/react/performance/timeline` that's not coupled with any rendering logic. Differential Revision: D55646391
rubennorte
force-pushed
the
export-D55646391
branch
from
97f7e16
to
35b1a4d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55646391 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Apr 9, 2024
Summary: Pull Request resolved: facebook#43854 Changelog: [internal] ## Context This is part of a refactor to decouple the performance entry reporter from the rendering infra and from the native module that uses it. ## Changes This moves the `PerformanceEntryReporter` and related classes to their own target in `ReactCommon/react/performance/timeline` that's not coupled with any rendering logic. Reviewed By: sammy-SC Differential Revision: D55646391
rubennorte
force-pushed
the
export-D55646391
branch
from
35b1a4d
to
8cb4a64
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55646391 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Apr 9, 2024
Summary: Pull Request resolved: facebook#43854 Changelog: [internal] ## Context This is part of a refactor to decouple the performance entry reporter from the rendering infra and from the native module that uses it. ## Changes This moves the `PerformanceEntryReporter` and related classes to their own target in `ReactCommon/react/performance/timeline` that's not coupled with any rendering logic. Reviewed By: sammy-SC Differential Revision: D55646391
rubennorte
force-pushed
the
export-D55646391
branch
from
8cb4a64
to
068a34a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55646391 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Apr 9, 2024
Summary: Pull Request resolved: facebook#43854 Changelog: [internal] ## Context This is part of a refactor to decouple the performance entry reporter from the rendering infra and from the native module that uses it. ## Changes This moves the `PerformanceEntryReporter` and related classes to their own target in `ReactCommon/react/performance/timeline` that's not coupled with any rendering logic. Reviewed By: sammy-SC Differential Revision: D55646391
rubennorte
force-pushed
the
export-D55646391
branch
from
068a34a
to
1f1e73e
Compare
Differential Revision: D55646390
Differential Revision: D55646393
Differential Revision: D55646394
Summary: Pull Request resolved: facebook#43854 Changelog: [internal] ## Context This is part of a refactor to decouple the performance entry reporter from the rendering infra and from the native module that uses it. ## Changes This moves the `PerformanceEntryReporter` and related classes to their own target in `ReactCommon/react/performance/timeline` that's not coupled with any rendering logic. Reviewed By: sammy-SC Differential Revision: D55646391
|
This pull request was exported from Phabricator. Differential Revision: D55646391 |
rubennorte
force-pushed
the
export-D55646391
branch
from
1f1e73e
to
7d00bdb
Compare
|
This pull request has been merged in c61c80b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
Context
This is part of a refactor to decouple the performance entry reporter from the rendering infra and from the native module that uses it.
Changes
This moves the
PerformanceEntryReporterand related classes to their own target inReactCommon/react/performance/timelinethat's not coupled with any rendering logic.Differential Revision: D55646391